[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r993258 - /subversion/trunk/subversion/mod_dav_svn/reports/log.c

From: Senthil Kumaran S <senthil_at_collab.net>
Date: Tue, 07 Sep 2010 13:19:42 +0530

Hi Bert,

rhuijben_at_apache.org wrote:
> Author: rhuijben
> Date: Tue Sep 7 07:32:34 2010
> New Revision: 993258
>
> URL: http://svn.apache.org/viewvc?rev=993258&view=rev
> Log:
> * subversion/mod_dav_svn/reports/log.c
> (dav_svn__log_report): Partially revert r993246 to fix compilation.
> The malformed_element_error() function is not defined nor a public
> api.

I was about to commit the attached patch in order to fix this, but I saw your
commit before that. Since malformed_element_error() is used in many files I
think we make this subversion private.

Thank You.

-- 
Senthil Kumaran S
http://www.stylesen.org/

[[[
Follow up r993183.

* subversion/mod_dav_svn/reports/log.c
  (malformed_element_error): Add this static function to return
   malformed errors. Ideally this should go into the private headers
   since its used in many files, which I ll do on a separate commit.
]]]

Index: subversion/mod_dav_svn/reports/log.c
===================================================================
--- subversion/mod_dav_svn/reports/log.c (revision 993224)
+++ subversion/mod_dav_svn/reports/log.c (working copy)
@@ -82,7 +82,21 @@
   return SVN_NO_ERROR;
 }
 
+/* Return a specific error associated with the contents of TAGNAME
+ being malformed. Use pool for allocations. */
+static dav_error *
+malformed_element_error(const char *tagname, apr_pool_t *pool)
+{
+ return dav_svn__new_error_tag(pool, HTTP_BAD_REQUEST, 0,
+ apr_pstrcat(pool,
+ "The request's '", tagname,
+ "' element is malformed; there "
+ "is a problem with the client.",
+ NULL),
+ SVN_DAV_ERROR_NAMESPACE, SVN_DAV_ERROR_TAG);
+}
 
+
 /* This implements `svn_log_entry_receiver_t'.
    BATON is a `struct log_receiver_baton *'. */
 static svn_error_t *
Received on 2010-09-07 09:50:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.