[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH]svnrdump to dump single specified revision

From: Ramkumar Ramachandra <artagnon_at_gmail.com>
Date: Mon, 6 Sep 2010 22:57:25 +0530

Hi Vijayguru,

Vijayaguru Guruchave writes:
> 'svnrdump dump -r n <URL>' dumps the revisions from 'n' to HEAD.The attached patch dumps the single specified revision alone.
> [[[
> Log:
> svnrdump to dump the single specified revision.
>
> * subversion/svnrdump/svnrdump.c
> (main): Dump the single specified revision by assigning start_revision to end_revision while passing revision number to '-r' option.
>
> Patch by: Vijayaguru G <vijay_at_collab.net>
> ]]]

Thanks for the patch. Although this was intended behavior, I figured
that `svnadmin` follows the convention of your patch.

Committed to r993102:

Index: subversion/svnrdump/svnrdump.c
===================================================================
--- subversion/svnrdump/svnrdump.c (revision 992366)
+++ subversion/svnrdump/svnrdump.c (working copy)
@@ -58,8 +58,7 @@ static const svn_opt_subcommand_desc2_t svnrdump__
       N_("usage: svnrdump dump URL [-r LOWER[:UPPER]]\n\n"
          "Dump revisions LOWER to UPPER of repository at remote URL "
          "to stdout in a 'dumpfile' portable format.\n"
- "If omitted, LOWER defaults to zero and UPPER to the latest "
- "latest revision.\n"),
+ "If only LOWER is given, dump that one revision.\n"),
       { 0 } },
     { "load", load_cmd, { 0 },
       N_("usage: svnrdump load URL\n\n"
@@ -75,7 +74,7 @@ static const svn_opt_subcommand_desc2_t svnrdump__
 
 static const apr_getopt_option_t svnrdump__options[] =
   {
- {"revision", 'r', 1, N_("REV1[:REV2] range of revisions to dump")},
+ {"revision", 'r', 1, N_("specify revision number ARG (or X:Y range)")},
     {"quiet", 'q', 0, N_("no progress (only errors) to stderr")},
     {"config-dir", opt_config_dir, 1, N_("read user configuration files from"
                                             " directory ARG") },
@@ -471,7 +470,10 @@ main(int argc, const char **argv)
                                                                 NULL, 10);
               }
             else
- opt_baton->start_revision = (svn_revnum_t)strtoul(opt_arg, NULL, 10);
+ {
+ opt_baton->start_revision = (svn_revnum_t)strtoul(opt_arg, NULL, 10);
+ opt_baton->end_revision = opt_baton->start_revision;
+ }
           }
           break;
         case 'q':
Received on 2010-09-06 19:30:04 CEST

This is an archived mail posted to the Subversion Dev mailing list.