[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r992886 - in /subversion/trunk/subversion/libsvn_wc: wc-queries.sql wc_db.c

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: Mon, 6 Sep 2010 12:09:04 +0200

On Mon, Sep 6, 2010 at 11:35 AM, Bert Huijben <bert_at_qqmail.nl> wrote:

>
> > + SVN_ERR(svn_sqlite__get_statement(&stmt, pdh->wcroot->sdb,
> > + STMT_INSERT_NODE_DATA));
> > +
> > + SVN_ERR(svn_sqlite__bindf(stmt, "isi", pdh->wcroot->wc_id, base,
> > + (apr_int64_t) 0 /* BASE */
> > + ));
> > + SVN_ERR(svn_sqlite__bind_text(stmt, 4, ""));
> > + SVN_ERR(svn_sqlite__bind_token(stmt, 5, presence_map,
> > + svn_wc__db_status_normal));
> > + SVN_ERR(svn_sqlite__bind_token(stmt, 6, kind_map,
> > + svn_wc__db_kind_subdir));
>
> Why don't you use _bindf("isistt", ...) here?
> That would include all the other fields. (Other option: separate binds of
> all values)
>
>
Right. We have many situations where we could/should bind all values through
..._bindf(). This was merely duplicating what was exactly above it. I prefer
the ..._bindf() version myself, but didn't want to rewrite existing code to
use it. Based on your feedback, I think I just might do that anyway, when in
the same function.

Bye,

Erik.
Received on 2010-09-06 12:09:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.