[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r979193 - in /subversion/branches/performance/subversion: include/private/svn_cache.h libsvn_subr/cache-membuffer.c

From: Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>
Date: Mon, 06 Sep 2010 02:17:33 +0200

Lieven Govaerts wrote:
> On Mon, Aug 30, 2010 at 2:57 PM, C. Michael Pilato <cmpilato_at_collab.net> wrote:
>
>> On 08/30/2010 06:31 AM, Stefan Fuhrmann wrote:
>>
>>> However, I simply fail to identify the typos you are referring
>>> to below. Could you give me the search&replacement spec
>>> ("s/typpo/typo/")?
>>>
>>>
>>>>> + * to 2 times the average hit count.
>>>>> + */
>>>>> + average_hits = cache->hit_count / cache->used_entries;
>>>>>
>>>> Typo.
>>>>
>
> Hm, this was misquoted from my mail. The typo is meant for the word
> "threashold" in the comment:
> + /* Roll the dice and determine a threashold somewhere from 0 up
>
>
>> I can't spot this one, either.
>>
>>
>>>>> + c->group_count = directory_size / sizeof (entry_group_t);
>>>>>
>>>> And here.
>>>>
>
> Yes, my mistake. This "and here" is not about the typo, but about a
> "implicit conversion
> shortens 64-bit value into a 32-bit value" warning.
>
> Lieven
>
>
Thanks for clearing that up!
The issues should be fixed now.

-- Stefan^2.
Received on 2010-09-06 02:18:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.