Re: svn commit: r991619 - in /subversion/trunk/subversion: include/private/svn_wc_private.h libsvn_client/commit.c libsvn_client/commit_util.c libsvn_client/merge.c libsvn_wc/entries.c libsvn_wc/node.c

On Wed, Sep 1, 2010 at 13:44, <julianfoad_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/include/private/svn_wc_private.h Wed Sep  1 17:44:41 2010
> @@ -394,6 +394,7 @@ svn_wc__node_is_status_deleted(svn_boole
>                                const char *local_abspath,
>                                apr_pool_t *scratch_pool);
>
> +#if 0  /* not required with SINGLE_DB */

Shouldn't this be #ifdef SVN_WC__SINGLE_DB ? I thought the idea was
to keep using that define for a while so that developers can compile
multi-db for testing purposes.

Now... I recognize that symbol is not available to libsvn_client which
then means that multi-db isn't possible any more? Maybe a more
appropriate approach would be to just leave the functions as stubs?
And then some ### markers to fully remove them when we strip out all
the multi-db code? (in a couple weeks?)

>...

Cheers,
-g
Received on 2010-09-02 02:16:19 CEST