[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r990916 - in /subversion/trunk/subversion/bindings/javahl/native: ClientContext.cpp ClientContext.h

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Tue, 31 Aug 2010 09:26:12 +0100

"Bert Huijben" <bert_at_qqmail.nl> writes:

> (I see a completely different test failure on the Windows bot)

On Linux I get the same as Hyrum.

> Can you run this same test with single-db?

In single-db on Linux I get 3 Failures rather than 1 Error:

.....................F..F..F................
.........
Time: 139.136
There were 3 failures:
1) testBasicRevert(org.tigris.subversion.javahl.BasicTests)junit.framework.AssertionFailedError: status not found in working copy: A/B/E/alpha
        at org.tigris.subversion.javahl.WC.check(WC.java:466)
        at org.tigris.subversion.javahl.SVNTests$OneTest.checkStatus(SVNTests.java:851)
        at org.tigris.subversion.javahl.SVNTests$OneTest.checkStatus(SVNTests.java:833)
        at org.tigris.subversion.javahl.BasicTests.testBasicRevert(BasicTests.java:1359)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at org.tigris.subversion.javahl.RunTests.main(RunTests.java:116)
2) testBasicDelete(org.tigris.subversion.javahl.BasicTests)junit.framework.AssertionFailedError: removed versioned dir
        at org.tigris.subversion.javahl.BasicTests.testBasicDelete(BasicTests.java:1640)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at org.tigris.subversion.javahl.RunTests.main(RunTests.java:116)
3) testBasicNodeKindChange(org.tigris.subversion.javahl.BasicTests)junit.framework.AssertionFailedError: can change node kind
        at org.tigris.subversion.javahl.BasicTests.testBasicNodeKindChange(BasicTests.java:1743)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at org.tigris.subversion.javahl.RunTests.main(RunTests.java:116)

FAILURES!!!
Tests run: 50, Failures: 3, Errors: 0

> The current recursive lock code for multi-db doesn't have stable behavior
> over added and removed directories, while the single-db code has. I didn't
> feel like reinventing a complete lock store system like the old access
> batons just to fix these issues for multi-db. (Single-db has a real
> recursive lock, so it only has to delete the lock from the root)

The recursive lock is a problem for non-recursive revert as it no
longer returns SVN_ERR_WC_NOT_LOCKED, see the XFail in revert_tests.py
(and our client explicitly checks for that error). We can fix the
recursive behaviour of revert, but can we fix the return value? Is it
acceptable to return SVN_ERR_WC_NOT_LOCKED when we have a recursive lock?

-- 
Philip
Received on 2010-08-31 10:27:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.