[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r986605 - in /subversion/branches/performance/subversion: include/private/svn_cache.h libsvn_subr/cache-inprocess.c libsvn_subr/cache-membuffer.c libsvn_subr/cache-memcache.c libsvn_subr/cache.c libsvn_subr/cache.h

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Sat, 28 Aug 2010 11:28:17 +0200

On Wed, Aug 18, 2010 at 11:21 AM, <stefan2_at_apache.org> wrote:
> Author: stefan2
> Date: Wed Aug 18 09:21:18 2010
> New Revision: 986605
>
> URL: http://svn.apache.org/viewvc?rev=986605&view=rev
> Log:
> Extend cache API with a function that effectively allows partial de-
> serialization as an alternative to the mandatory full de-serialization
> in svn_cache__get. This can be used to read a single element from
> a cached container, for instance.
>
> * subversion/include/private/svn_cache.h
>  (svn_cache__partial_getter_func_t): declare new callback type
>  (svn_cache__get_partial): declare new API function
>
> * subversion/libsvn_subr/cache.h
>  (svn_cache__vtable_t): extend vtable
> * subversion/libsvn_subr/cache.c
>  (svn_cache__get_partial): implement new API function
>
> * subversion/libsvn_subr/cache-memcache.c
>  (memcache_get_partial): implement new API for memcached caches
>  (memcache_vtable): extend vtable
> * subversion/libsvn_subr/cache-membuffer.c
>  (membuffer_cache_get_partial, svn_membuffer_cache_get_partial):
>   implement new API for membuffer caches
>
[..]

> +svn_error_t*
> +membuffer_cache_get_partial(svn_membuffer_t *cache,
> +                            const void *key,
> +                            apr_size_t key_len,
> +                            void **item,
> +                            svn_cache__partial_getter_func_t deserializer,
> +                            void *baton,
> +                            apr_pool_t *pool)
> +{

This function should probably be static? Results in a gcc warning now.

Lieven
Received on 2010-08-28 11:29:35 CEST

This is an archived mail posted to the Subversion Dev mailing list.