[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

is_wclocked() walks upwards out of a WC root

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Fri, 27 Aug 2010 18:36:29 +0100

I just noticed that the "entries-dump" test helper program can abort
with

/home/julianfoad/src/subversion-p/subversion/libsvn_subr/io.c:1933:
(apr_err=235000)
svn: In file
'/home/julianfoad/src/subversion-p/subversion/libsvn_wc/wc_db.c' line
522: assertion failed ((pdh)->wcroot != NULL && (pdh)->wcroot->format ==
SVN_WC__VERSION)

if called on a format-19 (single-DB) WC that exists
at ./obj-dir/subversion/tests/cmdline/svn-test-work/working_copies/merge_tests-16
where the directory '.' is a format-18 WC.

The problem is that is_wclocked() recurses upwards to look for a lock in
the parent directory, even when it is currently pointing at the WC root.

That's simply wrong and it should stop when it reaches the wc root (when
local_relpath = '', if we can make it aware of its local_relpath)?

Yes?

- Julian
Received on 2010-08-27 19:37:27 CEST

This is an archived mail posted to the Subversion Dev mailing list.