[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: httpd trunk broken with Subversion: ap_log_rerror busted

From: Justin Erenkrantz <justin_at_erenkrantz.com>
Date: Wed, 25 Aug 2010 08:31:05 -0700

On Wed, Aug 25, 2010 at 4:48 AM, Stefan Fritsch <sf_at_sfritsch.de> wrote:
> I agree that the comments/documentation should be improved. I will write a
> how-to for adjusting modules to the new API.

Here is a constructive suggestion (*grin*): in APR, for some of the
more complex declarations (see apr_pools.h and apr_pool_create), what
we have done is to create a #ifdef DOXYGEN tag which indicates the
normalized reduced form of the function declaration. The #else clause
contains the optimized, macro-ized version. (In httpd, I don't know
what the appropriate #ifdef should be though.)

This way those reading http_log.h will be able to see what the
declaration for ap_log_rerror actually reduces to without trying to go
through several layers of indirection. -- justin
Received on 2010-08-25 17:31:42 CEST

This is an archived mail posted to the Subversion Dev mailing list.