[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r988627 - in /subversion/trunk/subversion: bindings/javahl/native/ include/ libsvn_client/ svn/

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 25 Aug 2010 11:55:47 +0100

On Tue, 2010-08-24, hwright_at_apache.org wrote:
> Log:
> Move the commit callback out of the client context and into the individual APIs
> which require it.

Hurrah!

Reviewed and looks good.

- Julian

> * subversion/bindings/javahl/native/SVNClient.cpp
> (remove, commit, copy, move, mkdir, doImport, propertySet): Set the callback
> as a param, rather than in the client context.
>
> * subversion/svn/propdel-cmd.c,
> subversion/svn/move-cmd.c,
> subversion/svn/mkdir-cmd.c,
> subversion/svn/copy-cmd.c,
> subversion/svn/commit-cmd.c,
> subversion/svn/propset-cmd.c,
> subversion/svn/delete-cmd.c,
> subversion/svn/import-cmd.c,
> subversion/svn/propedit-cmd.c:
> Update API consumers to provide the commit callback.
>
> * subversion/svn/main.c
> (main): Don't set the commit callback context members.
>
> * subversion/include/svn_client.h
> (svn_client_ctx_t): Remove the commit callback and baton members.
> (svn_client_mkdir4, svn_client_delete4, svn_client_import4,
> svn_client_commit5, svn_client_copy6, svn_client_move6, svn_client_propset4):
> Add commit callback parameters.
>
> * subversion/libsvn_client/deprecated.c
> (capture_baton_t): Remove unneded members.
> (capture_commit_info): Just dup the commit info and exit.
> (svn_client_mkdir3, svn_client_import3, svn_client_delete3,
> svn_client_commit4, svn_client_copy5, svn_client_move5, svn_client_propset3):
> Remove the use of the shadow baton.
>
> * subversion/libsvn_client/delete.c,
> subversion/libsvn_client/prop_commands.c,
> subversion/libsvn_client/copy.c,
> subversion/libsvn_client/add.c,
> subversion/libsvn_client/commit.c:
> Explicitly pass around the commit callback and baton, rather than relying
> on the client context.
[...]
Received on 2010-08-25 12:56:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.