[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r987872 - in /subversion/branches/performance/subversion: include/private/svn_temp_serializer.h libsvn_fs_fs/dag.c libsvn_subr/svn_temp_serializer.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 22 Aug 2010 21:37:14 +0300

stefan2_at_apache.org wrote on Sun, Aug 22, 2010 at 11:43:48 -0000:
> Author: stefan2
> Date: Sun Aug 22 11:43:47 2010
> New Revision: 987872
>
> URL: http://svn.apache.org/viewvc?rev=987872&view=rev
> Log:
> Build file generation scripts don't handle uppercase identifiers.
> Therefore, we can't have NULL or similar substrings in public identifiers.
>
> * subversion/include/private/svn_temp_serializer.h
> (svn_temp_serializer__set_null): rename from svn_temp_serializer__set_NULL
>
> Patch by: Johan Corveleyn <jcorvel_at_gmail.com>

Guys, would this be a better fix?

[[[
Index: build/generator/extractor.py
===================================================================
--- build/generator/extractor.py (revision 987515)
+++ build/generator/extractor.py (working copy)
@@ -34,7 +34,7 @@
 # or
 # void svn_foo_bar (args)
 #
-_funcs = re.compile(r'^(?:(?:(?:\w+|\*) )+\*?)?((?:svn|apr)_[a-z_0-9]+)\s*\(', re.M)
+_funcs = re.compile(r'^(?:(?:(?:\w+|\*) )+\*?)?((?:svn|apr)_[A-Za-z_0-9]+)\s*\(', re.M)
 
 def extract_funcs(fname):
   funcs = [ ]
]]]

Note: this is completely untested, since I'm not on Windows right now.

Daniel
(by the way, I found that file by doing 'grep -Rl kwallet ./build/' ---
which I did because I remembered seeing the svn_*kwallet* functions
added to the list of exceptions in the same file that handled parsing
out identifiers-to-be-exported on Windows. I'm feeling old now...)
Received on 2010-08-22 20:40:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.