[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Performance branch ready for review

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sun, 22 Aug 2010 21:03:51 +0300

Stefan, you did mention "Patch by" for Johan's patches which you
committed, did you intend to mention "Found by" or "Suggested by" for
the other two (quoted below)?

http://subversion.apache.org/docs/community-guide/conventions.html#crediting

Thanks,

Daniel

Stefan Fuhrmann wrote on Sun, Aug 22, 2010 at 14:56:46 +0200:
> Johan Corveleyn wrote:
>> 4) In temp_serializer.c, some of the sizeof statements gave problems for me:
>> I changed them as follows (not sure if this is correct, but this compiles ok):
>> [[[
>> Index: subversion/libsvn_fs_fs/temp_serializer.c
>> ===================================================================
>> --- subversion/libsvn_fs_fs/temp_serializer.c (revision 986928)
>> +++ subversion/libsvn_fs_fs/temp_serializer.c (working copy)
>> @@ -271,7 +271,7 @@
>> ]]]
>>
>>
> I think your patch would work in almost all real-world applications.
> As I understand it, however, [...]
>
> Fixed in r987869.

>> I haven't been able to resolve these ...
>>
> Fixed in r987886.
Received on 2010-08-22 20:07:08 CEST

This is an archived mail posted to the Subversion Dev mailing list.