[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r986521 - in /subversion/branches/performance/subversion: libsvn_fs_fs/id.c libsvn_fs_fs/temp_serializer.c libsvn_subr/svn_temp_serializer.c

From: Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>
Date: Sun, 22 Aug 2010 14:39:54 +0200

Johan Corveleyn wrote:
> On Wed, Aug 18, 2010 at 1:11 AM, <stefan2_at_apache.org> wrote:
>
>> Author: stefan2
>> Date: Tue Aug 17 23:11:13 2010
>> New Revision: 986521
>>
>> URL: http://svn.apache.org/viewvc?rev=986521&view=rev
>> Log:
>> Change serialized representation of pointers: instead of storing offsets
>> relative to the whole buffer, store the offset relative to the (local) structure
>> that immediately contains that pointer as an element.
>>
>> Also, store directory content hashes in lexicographical order of their names.
>> This will soon be used to implement sub-entry cache access.
>>
>>
>
> This change caused this compilation error for me (on Windows, with
> Visual C Express 2008):
>
> ..\..\..\subversion\libsvn_fs_fs\temp_serializer.c(287): error C2065:
> 'comparison_fn_t' : undeclared identifier
> ..\..\..\subversion\libsvn_fs_fs\temp_serializer.c(287): error C4047:
> 'function' : 'int (__cdecl *)(const void *,const void *)' differs in
> levels of indirection from 'int'
> ..\..\..\subversion\libsvn_fs_fs\temp_serializer.c(287): error C4024:
> 'qsort' : different types for formal and actual parameter 4
> ..\..\..\subversion\libsvn_fs_fs\temp_serializer.c(287): error C2146:
> syntax error : missing ')' before identifier 'compare_dirent_id_names'
> ..\..\..\subversion\libsvn_fs_fs\temp_serializer.c(287): error C2059:
> syntax error : ')'
>
> Unless I missed something or did something wrong (had to resolve some
> merge conflicts, because I had made some changes to get it to compile
> -> see other thread).
>
>
Thanks for the feedback. r987868 should fix this
(I haven't gotten back home to test this on LINUX again).

-- Stefan^2.
Received on 2010-08-22 14:40:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.