[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r987592 - /subversion/trunk/subversion/libsvn_ra_neon/util.c

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 20 Aug 2010 18:34:02 -0400

On Fri, Aug 20, 2010 at 13:58, <julianfoad_at_apache.org> wrote:
>...
> +++ subversion/trunk/subversion/libsvn_ra_neon/util.c Fri Aug 20 17:58:10 2010
>...
> -static ne_xml_parser *
> +/* Create a status parser attached to the request REQ.  Detected errors
> +   will be returned there. */
> +static void
>  multistatus_parser_create(svn_ra_neon__request_t *req)
>  {
>   multistatus_baton_t *b = apr_pcalloc(req->pool, sizeof(*b));
> -  ne_xml_parser *multistatus_parser =
> -    svn_ra_neon__xml_parser_create(req, ne_accept_207,
> -                                   start_207_element,
> -                                   svn_ra_neon__xml_collect_cdata,
> -                                   end_207_element, b);
> +
> +  svn_ra_neon__xml_parser_create(req, ne_accept_207,

Woah. You should have a (void) cast in there and (or?) a comment
noting that the return value is not used. Otherwise, it looks like a
programming error.

>...

Cheers,
-g
Received on 2010-08-21 00:34:41 CEST

This is an archived mail posted to the Subversion Dev mailing list.