[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r987526 - /subversion/trunk/subversion/libsvn_wc/upgrade.c

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 20 Aug 2010 14:10:34 -0400

On Fri, Aug 20, 2010 at 14:01, Bert Huijben <bert_at_vmoo.com> wrote:
>
>
>> -----Original Message-----
>> From: Greg Stein [mailto:gstein_at_gmail.com]
>> Sent: vrijdag 20 augustus 2010 9:55
>> To: dev_at_subversion.apache.org
>> Subject: Re: svn commit: r987526 -
>> /subversion/trunk/subversion/libsvn_wc/upgrade.c
>>
>> On Fri, Aug 20, 2010 at 10:31,  <julianfoad_at_apache.org> wrote:
>> >...
>> > +++ subversion/trunk/subversion/libsvn_wc/upgrade.c Fri Aug 20 14:31:27
>> 2010
>> > @@ -1420,9 +1420,7 @@ svn_wc__upgrade_sdb(int *result_format,
>> >         /* ### TODO: Either upgrade to single-DB format here, or quit
>> >          * at format 18 and ask the user to run the external script
>> >          * 'tools/dev/wc-ng/bump-to-19.py'. */
>>
>> When you first checked in the script, I assumed you were doing that
>> for rapid dev/test. There is no way that I would ever support an
>> external script to perform this upgrade.
>
> I wouldn't have an issue with using a python script this if it is only used
> for upgrades from formats 12 to 18 to single-db. The upgrade from entries
> (read: 1.6.x and below) must be in c of course. But keeping the multi-db
> read code working for all the intermediate multi-db formats might provide
> too much overhead.
>
> We are not going to provide long-time support for these dev only
> intermediate formats anyway.

Agreed.

We're really looking at the upgrade_to_wcng() function in upgrade.c.
The other mid-term upgrades work for us, the developers, and also
establish a pattern for future upgrades.

Cheers,
-g
Received on 2010-08-20 20:11:09 CEST

This is an archived mail posted to the Subversion Dev mailing list.