[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r966822 - in /subversion/trunk/subversion: libsvn_client/repos_diff.c tests/cmdline/merge_tests.py

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Mon, 16 Aug 2010 09:40:34 +0100

On Thu, 2010-08-12, Paul Burba wrote:
> I'm working on that approach, but in the meantime I have a question
> about the behavior of svn diff --summarize when describing the
> addition of paths with properties.
>
> ### Let's take a vanilla greek tree, add a file and directory,
> ### set a prop on each, and commit as r2:
>
> >echo nu file > nu
>
> >svn add nu
> A nu
>
> >svn ps prop val nu
> property 'prop' set on 'nu'
>
> >svn mkdir J
> A J
>
> >svn ps prop val J
> property 'prop' set on 'J'
>
> ### Status looks right, two scheduled additions:
>
> >svn st
> A nu
> A J
>
> ### Commit it
>
> >svn ci -m ""
> Adding J
> Adding nu
> Transmitting file data .
> Committed revision 2.
>
> ### Check diff --summarize for r2
>
> >svn diff -r1:2 --summarize
> AM nu
> AM J
>
> Should we really be describing the props for this added (not copied!)
> file as modified? It seems incorrect to call the props modified in
> this case. I ask because this is one of the problems I am running
> into with fixing this issue in mod_dav_svn, and before I spend more
> time trying to "fix" it I want to be sure the current behavior is
> really what we expect.
>
> Paul "Dying slowly at the hands of mod_dav_svn" Burba

I would suggest that the output of "svn diff --summarize" should be
consistent with the likes of "svn add" (no 'M'), "svn status" (no 'M')
and "svn update" (I haven't checked this one).

- Julian
Received on 2010-08-16 10:41:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.