[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [WIP] Enable passing copyfrom information for the diff code when dealing with repository diffs.

From: Stefan Sperling <stsp_at_elego.de>
Date: Sun, 15 Aug 2010 22:12:38 +0200

On Sun, Aug 15, 2010 at 09:27:22PM +0200, Daniel Näslund wrote:
> Hi!
>
> Why doesn't svn_ra_do_diff3() request that the repository sends copyfrom
> args? The best explanation I've found is this commit message:
>
> ------------------------------------------------------------------------
> r866577 | sussman | 2007-09-10 06:56:55 +0200 (mån, 10 sep 2007) | 87 lines
>
> Send copyfrom-args on updates *only* if the client explicitly requests them.
>
> This keeps the 1.5 servers backward-compatible. Because incoming
> copyfrom args cause old clients to error, they should only be
> requested by new clients that understand them. This means adding a
> new boolean 'send_copyfrom_args' to the main libsvn_repos
> editor-driver, svn_ra_do_update2(), and all four RA implementations.
> Eesh!
>
> [.. Rest of log message omitted for brevity ..]
>
> I'm assuming noone saw a use case for having diff display copies back then and
> since it involved passing down a lot of parameters, only svn_ra_do_updateX()
> was revved. But with git diffs we have a use case for copyfrom info. How about
> enable it?

Yes, let's enable it. In the same backwards-compatible fashion of course.

Stefan
Received on 2010-08-15 22:13:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.