[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [patch] fsfs revprop packing paranoia

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 13 Aug 2010 11:13:10 +0100

Daniel Shahaf <d.s_at_daniel.shahaf.name> writes:

> I figure this patch can't do any harm (except cost another file-read when a
> write-lock or txn-current-lock is being acquired), and it might as well
> help, so I committed it in r984990.

>> @@ -594,7 +598,11 @@ static svn_error_t *
>> err = get_lock_on_filesystem(lock_filename, subpool);
>>
>> if (!err)
>> - err = body(baton, subpool);
>> + {
>> + SVN_ERR(update_min_unpacked_rev(fs, pool));
>> + SVN_ERR(update_min_unpacked_revprop(fs, pool));
>> + err = body(baton, subpool);
>> + }

This makes 1.6 repositories incompatible with the 1.7 client:

$ rm -rf repo && svnadmin create repo # using 1.6
$ subversion/svn/svn mkdir -mm file://`pwd`/repo/A # using 1.7
../src/subversion/libsvn_fs_fs/fs_fs.c:565: (apr_err=235000)
svn: In file '../src/subversion/libsvn_fs_fs/fs_fs.c' line 1199: assertion failed (ffd->format >= SVN_FS_FS__MIN_PACKED_REVPROP_FORMAT)
Aborted

-- 
Philip
Received on 2010-08-13 12:14:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.