On Thu, Aug 12, 2010 at 10:08 PM, Lieven Govaerts <svnlgo_at_mobsol.be> wrote:
> On Thu, Aug 12, 2010 at 9:59 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
>> stefan2_at_apache.org wrote on Thu, Aug 12, 2010 at 19:29:24 -0000:
>>> Author: stefan2
>>> Date: Thu Aug 12 19:29:23 2010
>>> New Revision: 984926
>>> URL: http://svn.apache.org/viewvc?rev=984926&view=rev
>>> Merge r983764 from branches/performance. Approved by: danielsh
>> Usually, the "Approved by:" appears on a separate line, and an accompanying URL
>> is not necessary. (See .)
>> I won't be bothered if these log messages aren't fixed, but please be aware
>> of the convention for next time.
> These conventions are there to make the contribulyzer work no?
> Not following these conventions means we have to pay attention to your
> work instead of having an automated tool do that for us :-).
Slightly off topic remark, but it would be nice if we could run
stefan's branch on the buildbots from time to time, would be
interesting to see the impact on the test run times.
Received on 2010-08-12 22:20:44 CEST