[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [atomic-revprops] status update

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 11 Aug 2010 11:33:49 +0100

On Wed, 2010-08-11, Stefan Sperling wrote:
> The BRANCH-README suggest that we add an interface like
> 'svn propedit --revprop pname pval2 --old-value=pval'.
> I don't think there is a valid use case for non-atomic revprop changes.
> Why not just make all revprop changes atomic by default if the client
> and server are both >= 1.7? Any propset/propedit operation could
> transparently retrieve the old value before trying to set the new value.

It makes sense for propEDIT to ensure that the old value it got is still
current when it sets the new value. It would be silly for that to be a
command-line option. It should always do it.

But for a propSET command, the old value that the user was looking at
before performing the set is not something that the command itself can
get. There's no point in the command retrieving the "current" value at
the time the propSET command is run, because that's not necessarily the
value the user was looking at - it's already too late. There is a case
for this command taking the expected old value from the user, not that a
command-line user is likely to provide it, but a script might. The API
behind it should certainly take this option so that GUIs etc. can use it
in implementing their own propedit-like functionality via the propset
API.

- Julian
Received on 2010-08-11 12:34:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.