[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Bug in svn_fs_paths_changed2() Python bindings?

From: Alexey Neyman <stilor_at_att.net>
Date: Tue, 10 Aug 2010 18:22:53 -0700

Okay, try again:

[[[
Fix the type of structures returned in bindings from svn_fs_paths_changed2().

* subversion/include/svn_fs.h
  (svn_fs_paths_changed2): Rename the argument from changed_paths_p to
  changed_paths_p2, so that it's different from argument to
  svn_fs_paths_changed().
* subversion/bindings/swig/svn_fs.i
  (changed_paths_p2): New %hash_argout_typemap, denotes apr_hash_t containing
  svn_fs_path_change2_t.
]]]

Regards,
Alexey.

On Tuesday, August 10, 2010 06:04:14 pm Hyrum K. Wright wrote:
> When submitting patches, it is helpful to provide a log message. (See
> http://subversion.apache.org/docs/community-guide/general.html#log-messages
> )
>
> Thanks,
> -Hyrum
>
> On Tue, Aug 10, 2010 at 7:38 PM, Alexey Neyman <stilor_at_att.net> wrote:
> > Small update to the patch: change doxygen comment to match new argument
> > name.
> >
> > Regards,
> > Alexey.
> >
> > On Tuesday, August 10, 2010 02:53:50 pm Alexey Neyman wrote:
> >> Hi all,
> >>
> >> Looks like the binding for svn_fs_paths_changed2() incorrectly specifies
> >> the type of structures contained in the hash it returns: the following
> >> code
> >>
> >> s = fs.paths_changed2(rev_root, pool)
> >> for i in s:
> >> sys.stderr.write("%s = %s\n" % (i, repr(s)))
> >>
> >> indicates that bindings assume the hash to contain svn_fs_path_change_t
> >> structures, not svn_fs_path_change2_t as it should (it's the difference
> >> between fs.paths_changed() and fs.paths_changed2(), actually).
> >>
> >> The attached patch fixes this issue.
> >>
> >> Regards,
> >> Alexey.

Received on 2010-08-11 03:23:39 CEST

This is an archived mail posted to the Subversion Dev mailing list.