[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r983807 - in /subversion/branches/atomic-revprop/subversion: include/svn_error.h libsvn_subr/error.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 11 Aug 2010 02:26:59 +0300

Julian Foad wrote on Tue, Aug 10, 2010 at 14:33:24 +0100:
> On Tue, 2010-08-10, Daniel Shahaf wrote:
> > +++ subversion/libsvn_subr/error.c (working copy)
> > @@ -274,9 +274,8 @@
> > {
> > svn_error_t *child;
> >
> > - if (! err && ! apr_err)
> > - /* The API doesn't specify the behaviour when ERR is NULL. */
> > - return TRUE;
> > + if (err == SVN_NO_ERROR)
> > + return FALSE;
>
> No need to implement this check as a special case: the general case loop
> below already does the same.

Okay. Committed in r984264.

Thanks,

Daniel
Received on 2010-08-11 01:29:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.