[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r983222 - /subversion/trunk/subversion/svnrdump/load_editor.c

From: Branko ─îibej <brane_at_xbc.nu>
Date: Sat, 07 Aug 2010 17:05:32 +0200

On 07.08.2010 16:32, Ramkumar Ramachandra wrote:
> Hi Daniel,
>
> Daniel Shahaf writes:
>
>> artagnon_at_apache.org wrote on Sat, Aug 07, 2010 at 12:31:50 -0000:
>>
>>> Author: artagnon
>>> Date: Sat Aug 7 12:31:50 2010
>>> New Revision: 983222
>>>
>>> URL: http://svn.apache.org/viewvc?rev=983222&view=rev
>>> Log:
>>> svnrdump: Fix a bug in the load_editor; it was unable to handle
>>> revisions without node information previously.
>>>
>>> * subversion/svnrdump/load_editor.c
>>> (close_revision): Add a new if-branch; if the commit_editor doesn't
>>> exist, create one, open_root and close_edit on it to indicate that
>>> we've finished processing the revision. While at it, also fix indentation.
>>>
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> I take it you haven't seen my previous commit review yet?
>>
> The trade-off is the creation of many trivial commits :)
>

We do have a long-standing preference to not mix functional and
stylistic changes in the same commit. It's even documented in Hacking.

-- Brane
Received on 2010-08-07 17:06:18 CEST

This is an archived mail posted to the Subversion Dev mailing list.