[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r979282 - in /subversion/trunk/subversion/svnrdump: dump_editor.c dump_editor.h load_editor.c load_editor.h svnrdump.c

From: Ramkumar Ramachandra <artagnon_at_gmail.com>
Date: Fri, 6 Aug 2010 21:00:10 +0530

Hi Kamesh and Philip,

Philip Martin writes:
> Kamesh Jayachandran <kamesh_at_collab.net> writes:
>
> > On 07/26/2010 07:25 PM, artagnon_at_apache.org wrote:
> >> Author: artagnon
> >> Date: Mon Jul 26 13:55:25 2010
> >> New Revision: 979282
> >>
> >> URL: http://svn.apache.org/viewvc?rev=979282&view=rev
> >> Log:
> >> svnrdump: Add an a no-op load editor
> >>
> >> * subversion/svnrdump/svnrdump.c
> >> (load_revisions): New function to fetch and drive the load
> >> editor. Currently just fetches the load editor.
> >> (load_cmd): Call load_revisions with the appropriate arguments.
> >>
> >> * subversion/svnrdump/load_editor.c
> >> (get_load_editor): Add a no-op load editor.
> >>
> >
> > Please name this function 'get_load_editor' as 'svnrdump__get_load_editor'.
>
> You also need to #include load_editor.h in load_editor.c to make the
> prototype visible (possibly instead of dump_editor.h?)

Sorry about the late response- there was a huge amount of development
and API changes over the last week. I'm sure you'll agree that it's
quite unpleasant to type "svnrdump___get_load_editor" into gdb
everytime during development. Ofcourse, when everything starts working
and the API becomes more stable, I'll expose all re-usable
functionality. Thank you for understanding.

Also, please mark me on the TO or CC when specifically addressing my
commits- I have to handle massive volumes of email everyday, and I
sometimes miss email on which I'm not marked.

Thanks again.

-- Ram
Received on 2010-08-06 17:32:11 CEST

This is an archived mail posted to the Subversion Dev mailing list.