[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r981893 - /subversion/trunk/subversion/libsvn_wc/status.c

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 3 Aug 2010 13:34:49 -0400

On Tue, Aug 3, 2010 at 10:13, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Tue Aug  3 14:13:10 2010
> New Revision: 981893
>
> URL: http://svn.apache.org/viewvc?rev=981893&view=rev
> Log:
> * subversion/libsvn_wc/status.c
>  (get_dir_status): In single-db don't use svn_wc__db_node_hidden, if we
>    already have status.

This seems like a dangerous disparity. It is exposing too much of
SINGLE_DB outside of wc_db.h.

I would very much encourage finding a way to collapse this under the
wc_db covers before continuing this pattern. Ideally, the only
SINGLE_DB conditions should be *inside* wc_db. If not, then something
is probably wrong in that API.

Cheers,
-g
Received on 2010-08-03 19:35:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.