Re: opening fsfs rev files rw

On Tue, 2010-08-03 at 18:19 +0300, Daniel Shahaf wrote:
> Daniel Shahaf wrote on Tue, Aug 03, 2010 at 11:58:32 +0300:
> > There was yesterday on IRC [1] some discussion around whether revprop
> > editing can corrupt rev files.
> >
> > [[[
> > 0:% rm -rf r
> > 0:% ./subversion/svnadmin/svnadmin create r
> > 0:% ls -l r/db/revs/0/0
> > -rw-r--r-- 1 daniel daniel 115 2010-08-03 11:56 r/db/revs/0/0
> > ]]]
> >
> > Shouldn't we create rev files with the write bit disabled? (i.e., 0222 umask)
>
> r981921 + nominated for backport.

The idea looks sane.

There's perhaps a problem with revPROPS files: fs_fs.c copies the
permissions of a revprops file from the corresponding rev file, which
now means all revprops files will be read-only, which might cause a
problem when trying to edit a revprop.

- Julian
Received on 2010-08-03 18:36:43 CEST