[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Tue, 3 Aug 2010 17:20:59 +0300

Simon Atanasyan wrote on Tue, Aug 03, 2010 at 12:28:20 +0400:
> On Mon, Aug 2, 2010 at 23:04, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> > Simon Atanasyan wrote on Mon, Aug 02, 2010 at 19:59:31 +0400:
> >> From the programmer's point of view if you create repository calling
> >> svn_fs_create with the new configuration option you easily get well commented
> >> db/fsfs.conf with necessary settings.
> >
> > svn_fs_create() already takes an FS_CONFIG parameter.  We could populate the
> > initially-created fsfs.conf with values from that parameter...
> If I understand you correctly my patch does exactly the same things.
> It checks file system configuration options in the write_config
> function (called from svn_fs_fs__create) and generates corresponded
> db/fsfs.conf.

The API part of the patch might be useful then.

Perhaps the patch would face more friendly winds if you retained the API
bit, but replaced --fsfs-no-rep-sharing by some more generic --config-option
flag? (compare 'svn --config-option')

(you may want to wait for others' opinions before implementing what I just said)

> --
> Simon Atanasyan
> VisualSVN Limited
Received on 2010-08-03 16:23:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.