[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r981665 - in /subversion/branches/performance/subversion: include/private/svn_file_handle_cache.h include/private/svn_temp_serializer.h libsvn_subr/svn_file_handle_cache.c libsvn_subr/svn_temp_serializer.c

From: Kamesh Jayachandran <kamesh_at_collab.net>
Date: Tue, 03 Aug 2010 14:40:21 +0530

On 08/03/2010 01:07 AM, stefan2_at_apache.org wrote:
> Author: stefan2
> Date: Mon Aug 2 19:36:59 2010
> New Revision: 981665
>
> URL: http://svn.apache.org/viewvc?rev=981665&view=rev
> Log:
> Rename all svn_* in include/private to svn__* as requested in
> http://svn.haxx.se/dev/archive-2010-08/0043.shtml
>
> * subversion/include/private/svn_file_handle_cache.h
> (svn_*): rename to svn__*
> * subversion/include/private/svn_temp_serializer.h
> (svn_*): rename to svn__*
>
> * subversion/libsvn_subr/svn_file_handle_cache.c
> (svn_*): rename to svn__*
> (lock_cache, unlock_cache, find_first, internal_file_open, internal_close_file,
> open_entry, close_oldest_idle, auto_close_oldest): adapt signatures
> (close_handle_before_cleanup): adapt implementation
> * subversion/libsvn_subr/svn_temp_serializer.c
> (svn_*): rename to svn__*
>
> Modified:
> subversion/branches/performance/subversion/include/private/svn_file_handle_cache.h
> subversion/branches/performance/subversion/include/private/svn_temp_serializer.h
> subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c
> subversion/branches/performance/subversion/libsvn_subr/svn_temp_serializer.c
>
> Modified: subversion/branches/performance/subversion/include/private/svn_file_handle_cache.h
> URL: http://svn.apache.org/viewvc/subversion/branches/performance/subversion/include/private/svn_file_handle_cache.h?rev=981665&r1=981664&r2=981665&view=diff
> ==============================================================================
> --- subversion/branches/performance/subversion/include/private/svn_file_handle_cache.h (original)
> +++ subversion/branches/performance/subversion/include/private/svn_file_handle_cache.h Mon Aug 2 19:36:59 2010
> @@ -20,7 +20,7 @@
> * ====================================================================
> * @endcopyright
> *
> - * @file svn_file_handle_cache.h
> + * @file svn__file_handle_cache.h
>

I guess it is a find and replace error. I mean file name still remains same.
> * @brief File handle cache API
> */
>
> @@ -30,14 +30,14 @@
> /**
> * An opaque structure representing a cache for open file handles.
> */
> -typedef struct svn_file_handle_cache_t svn_file_handle_cache_t;
> +typedef struct svn__file_handle_cache_t svn__file_handle_cache_t;
>
> /**
> * An opaque structure representing a cached file handle being used
> * by the calling application.
> */
> typedef
> -struct svn_file_handle_cache__handle_t svn_file_handle_cache__handle_t;
> +struct svn__file_handle_cache__handle_t svn__file_handle_cache__handle_t;
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * Get an open file handle in @a f, for the file named @a fname with the
> @@ -51,14 +51,14 @@ struct svn_file_handle_cache__handle_t s
> * returned is undefined.
> */
> svn_error_t *
> -svn_file_handle_cache__open(svn_file_handle_cache__handle_t **f,
> - svn_file_handle_cache_t *cache,
> - const char *fname,
> - apr_int32_t flag,
> - apr_fileperms_t perm,
> - apr_off_t offset,
> - int cookie,
> - apr_pool_t *pool);
> +svn__file_handle_cache__open(svn__file_handle_cache__handle_t **f,
> + svn__file_handle_cache_t *cache,
> + const char *fname,
> + apr_int32_t flag,
> + apr_fileperms_t perm,
> + apr_off_t offset,
> + int cookie,
> + apr_pool_t *pool);
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * Efficiently check whether the file handle cache @a cache holds an open
> @@ -67,8 +67,8 @@ svn_file_handle_cache__open(svn_file_han
> * that the respective file does not exist.
> */
> svn_boolean_t
> -svn_file_handle_cache__has_file(svn_file_handle_cache_t *cache,
> - const char *fname);
> +svn__file_handle_cache__has_file(svn__file_handle_cache_t *cache,
> + const char *fname);
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * Return the APR level file handle underlying the cache file handle @a f.
> @@ -76,7 +76,7 @@ svn_file_handle_cache__has_file(svn_file
> * invalidated.
> */
> apr_file_t *
> -svn_file_handle_cache__get_apr_handle(svn_file_handle_cache__handle_t *f);
> +svn__file_handle_cache__get_apr_handle(svn__file_handle_cache__handle_t *f);
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * Return the name of the file that the cached handle @a f refers to.
> @@ -84,7 +84,7 @@ svn_file_handle_cache__get_apr_handle(sv
> * invalidated.
> */
> const char *
> -svn_file_handle_cache__get_name(svn_file_handle_cache__handle_t *f);
> +svn__file_handle_cache__get_name(svn__file_handle_cache__handle_t *f);
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * Return the cached file handle @a f to the cache. Depending on the number
> @@ -92,13 +92,13 @@ svn_file_handle_cache__get_name(svn_file
> * is NULL, already closed or an invalidated handle, this is a no-op.
> */
> svn_error_t *
> -svn_file_handle_cache__close(svn_file_handle_cache__handle_t *f);
> +svn__file_handle_cache__close(svn__file_handle_cache__handle_t *f);
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * Close all file handles currently not held by the application.
> */
> svn_error_t *
> -svn_file_handle_cache__flush(svn_file_handle_cache_t *cache);
> +svn__file_handle_cache__flush(svn__file_handle_cache_t *cache);
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * Creates a new file handle cache in @a cache. Up to @a max_handles
> @@ -109,7 +109,7 @@ svn_file_handle_cache__flush(svn_file_ha
> * cache, @a thread_safe may be @c FALSE. Otherwise, it must be @c TRUE.
> */
> svn_error_t *
> -svn_file_handle_cache__create_cache(svn_file_handle_cache_t **cache,
> - size_t max_handles,
> - svn_boolean_t thread_safe,
> - apr_pool_t *pool);
> +svn__file_handle_cache__create_cache(svn__file_handle_cache_t **cache,
> + size_t max_handles,
> + svn_boolean_t thread_safe,
> + apr_pool_t *pool);
>
>

having '__' in two places in an identifier looks bit odd.

> Modified: subversion/branches/performance/subversion/include/private/svn_temp_serializer.h
> URL: http://svn.apache.org/viewvc/subversion/branches/performance/subversion/include/private/svn_temp_serializer.h?rev=981665&r1=981664&r2=981665&view=diff
> ==============================================================================
> --- subversion/branches/performance/subversion/include/private/svn_temp_serializer.h (original)
> +++ subversion/branches/performance/subversion/include/private/svn_temp_serializer.h Mon Aug 2 19:36:59 2010
> @@ -38,7 +38,8 @@ struct svn_stringbuf_t;
> * Opaque structure controlling the serialization process and holding the
> * intermediate as well as final results.
> */
> -typedef struct svn_temp_serializer__context_t svn_temp_serializer__context_t;
> +typedef
> +struct svn__temp_serializer__context_t svn__temp_serializer__context_t;
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * Begin the serialization process for the @a source_struct and all objects
> @@ -57,11 +58,11 @@ typedef struct svn_temp_serializer__cont
> *
> * @return the serization context.
> */
> -svn_temp_serializer__context_t *
> -svn_temp_serializer__init(const void *source_struct,
> - apr_size_t struct_size,
> - apr_size_t suggested_buffer_size,
> - apr_pool_t *pool);
> +svn__temp_serializer__context_t *
> +svn__temp_serializer__init(const void *source_struct,
> + apr_size_t struct_size,
> + apr_size_t suggested_buffer_size,
> + apr_pool_t *pool);
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * Begin serialization of a referenced sub-structure within the
> @@ -75,9 +76,9 @@ svn_temp_serializer__init(const void *so
> * svn_serializer__pop to realign the serialization context.
> */
> void
> -svn_temp_serializer__push(svn_temp_serializer__context_t *context,
> - const void * const * source_struct,
> - apr_size_t struct_size);
> +svn__temp_serializer__push(svn__temp_serializer__context_t *context,
> + const void * const * source_struct,
> + apr_size_t struct_size);
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * End the serialization of the current sub-structure. The serialization
> @@ -88,7 +89,7 @@ svn_temp_serializer__push(svn_temp_seria
> * of the serialization process.
> */
> void
> -svn_temp_serializer__pop(svn_temp_serializer__context_t *context);
> +svn__temp_serializer__pop(svn__temp_serializer__context_t *context);
>

having '__' in two places in an identifier looks bit odd.

>
> /**
> * Serialize a string referenced from the current structure within the
> @@ -97,15 +98,15 @@ svn_temp_serializer__pop(svn_temp_serial
> * serialized structure can be established.
> */
> void
> -svn_temp_serializer__add_string(svn_temp_serializer__context_t *context,
> - const char * const * s);
> +svn__temp_serializer__add_string(svn__temp_serializer__context_t *context,
> + const char * const * s);
>

having '__' in two places in an identifier looks bit odd.
>
> /**
> * @return a reference to the data buffer containing the data serialialized
> * so far in the given serialization @a context.
> */
> struct svn_stringbuf_t *
> -svn_temp_serializer__get(svn_temp_serializer__context_t *context);
> +svn__temp_serializer__get(svn__temp_serializer__context_t *context);
>
>

having '__' in two places in an identifier looks bit odd.

> /**
> * Deserialization is straightforward: just copy the serialized buffer to
> @@ -117,4 +118,4 @@ svn_temp_serializer__get(svn_temp_serial
> * the pointer to resolve in @a ptr.
> */
> void
> -svn_temp_deserializer__resolve(void *buffer, void **ptr);
> +svn__temp_deserializer__resolve(void *buffer, void **ptr);
>

having '__' in two places in an identifier looks bit odd.

> Modified: subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c
> URL: http://svn.apache.org/viewvc/subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c?rev=981665&r1=981664&r2=981665&view=diff
> ==============================================================================
> --- subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c (original)
> +++ subversion/branches/performance/subversion/libsvn_subr/svn_file_handle_cache.c Mon Aug 2 19:36:59 2010
> @@ -1,5 +1,5 @@
> /*
> - * svn_file_handle_cache.c: open file handle caching for Subversion
> + * svn__file_handle_cache.c: open file handle caching for Subversion
> *
>

I guess it is a find and replace error. I mean file name still remains same.

Thanks
With regards
Kamesh Jayachandran
Received on 2010-08-03 11:12:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.