[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[patch] fsfs revprop packing paranoia

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Mon, 2 Aug 2010 23:44:10 +0300

Is this necessary to avoid some race conditions around a revprop becoming
packed just before commit_body()'s write-lock had been acquired?

[[[
Index: fs_fs.c
===================================================================
--- fs_fs.c (revision 981659)
+++ fs_fs.c (working copy)
@@ -6094,6 +6094,7 @@ commit_body(void *baton, apr_pool_t *pool)
   SVN_ERR(svn_fs_fs__change_txn_prop(cb->txn, SVN_PROP_REVISION_DATE,
                                      &date, pool));
 
+ SVN_ERR(update_min_unpacked_revprop(fs, pool));
   if (ffd->format < SVN_FS_FS__MIN_PACKED_REVPROP_FORMAT ||
       new_rev >= ffd->min_unpacked_revprop)
     {
]]]

Daniel
(sorry, haven't dived deeply into it; I need to get up in 6 hours)
Received on 2010-08-02 22:46:22 CEST

This is an archived mail posted to the Subversion Dev mailing list.