[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r980811 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.h fs_fs.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Sun, 1 Aug 2010 22:55:13 +0200

On Sun, Aug 01, 2010 at 03:58:14PM +0200, Bert Huijben wrote:
> I don't think we should remove the '/db' part here.
>
> At the repos layer the '/db' doesn't make sense, but this is an
> implementation on the 'fs' layer and there the 'db' does make sense.
>
> (And if we decide to remove /db here, we should remove it in at least
> a dozen other error messages defined in
> subversion/include/private/svn_fs_util.h. (I actually wrote a patch to
> do that a few days ago, but then I found the different layering).

Well, this may be a layer violation.
But to guide users, I'd like to print the command users can use to fix
the problem in the error message. Can you suggest a better way to achive
that without violating layers? If not, I'd rather keep the error message
as is. I can live with trivial layer violations like this one if it helps
users.

Stefan
Received on 2010-08-01 22:55:56 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.