[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r980811 - in /subversion/trunk/subversion/libsvn_fs_fs: fs.h fs_fs.c

From: 'Stefan Sperling' <stsp_at_elego.de>
Date: Sun, 1 Aug 2010 12:47:51 +0200

On Sun, Aug 01, 2010 at 10:39:04AM +0200, Bert Huijben wrote:
> > + if (APR_STATUS_IS_ENOENT(err->apr_err))
> > + {
> > + /* 1.6.0 to 1.6.11 did not copy the configuration file
> > during
> > + * hotcopy. So if we're hotcopying a repository which
> > has been
> > + * created as a hotcopy itself, it's possible that
> > fsfs.conf
> > + * does not exist. Ask the user to re-create it.
> > + *
> > + * ### It would be nice to make this a non-fatal error,
> > + * ### but this function does not get an svn_fs_t object
> > + * ### so we have no way of just printing a warning via
> > + * ### the fs->warning() callback. */
> > +
> > + const char *msg;
> > + const char *src_abspath;
> > + const char *dst_abspath;
> > + const char *config_relpath;
> > +
>
> You leak the error in err here.

No, because we quick_wrap it later:

> > + return svn_error_return(svn_error_quick_wrap(err, msg));
                                            ^^^^^^^^^^^^^^^^^^^^^^^^
> > + }
> > + else
> > + return svn_error_return(err);
> > + }
> > + }
> > +
Received on 2010-08-01 12:48:34 CEST

This is an archived mail posted to the Subversion Dev mailing list.