Re: svn commit: r981090 - in /subversion/branches/performance/subversion: include/private/svn_serializer.h libsvn_subr/svn_serializer.c

On Sat, Jul 31, 2010 at 18:22, Blair Zajac <blair_at_orcaware.com> wrote:
>
> On Jul 31, 2010, at 1:28 PM, stefan2_at_apache.org wrote:
>
>> Author: stefan2
>> Date: Sat Jul 31 20:28:49 2010
>> New Revision: 981090
>>
>> URL: http://svn.apache.org/viewvc?rev=981090&view=rev
>> Log:
>> Introduce a simple serialization framework that simplifies and
>> speeds up serialization of most data structures used by FSFS,
>> for instance.
>
> Instead of rolling another serialization in svn, what about using protobuf for C?
>
> http://code.google.com/p/protobuf-c/
>
> I has an Apache 2 license, so will be compatible with us.
>
> Another one to consider is using Thrift, which writes C code:
>
> http://wiki.apache.org/thrift/
>
> On advantage to these serialization tools is that they are extensible, so we can always add additional fields to the serialized structs and not break binary compatibility.

Not to mention our skel implementation.

But the big thing here is that this serializer creates non-portable
files. IIRC, FSFS was designed to have portable files. (where
"portable" means across architectures, byte alignments, etc)

And style nit: we *never* use upper-case typedef names (and generally
avoid hungarian notation concepts).

Cheers,
-g
Received on 2010-08-01 08:15:23 CEST