[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r981091 - in /subversion/branches/performance/subversion: include/private/svn_file_cache.h libsvn_subr/svn_file_cache.c

From: Blair Zajac <blair_at_orcaware.com>
Date: Sat, 31 Jul 2010 17:33:40 -0700

On 7/31/10 1:47 PM, stefan2_at_apache.org wrote:
> Author: stefan2
> Date: Sat Jul 31 20:46:59 2010
> New Revision: 981091
>
> URL: http://svn.apache.org/viewvc?rev=981091&view=rev
> Log:
> Introduce a private file handle cache API and provide an implementation.
>
> * subversion/include/private/svn_file_cache.h
> (svn_file_cache_t, svn_file_cache__handle_t): introduce new opaque data types
> (svn_file_cache__open, svn_file_cache__has_file,
> svn_file_cache__get_apr_handle, svn_file_cache__get_name,
> svn_file_cache__close, svn_file_cache__flush, svn_file_cache__create_cache):
> declare new private API functions

The name svn_file_cache_t isn't clear that this is a file handle cache. A first
reading of it suggest that is a local cache for files (possibly remote). I
suggest renaming it to svn_file_handle_cache_t and all other functions.

Regards,
Blair
Received on 2010-08-01 02:34:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.