[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r959954 - /subversion/trunk/subversion/libsvn_wc/wc.h

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Fri, 30 Jul 2010 11:17:06 +0100

Bert Huijben wrote:
> > Looks like changed5.txt and changed7.txt have the same checksum here.
> > (The result of 'echo "" ' put into the file)
> >
> > That add-s checksum isn't recorded in the database yet during post
> > commit, when the delete operation is performed so the delete determines
> > that the pristine can safely be removed because nobody is looking at it?
>
> Ok, just confirmed this.
>
> See the regression test I added in r980672, based on your script.

Fixed in r980716. svn_wc__db_pristine_remove() now doesn't remove it if
the work queue is non-empty.

However there's more to do. The code already doesn't remove unused
pristines in all the places where it should, and this change fixes that
bug but also means even fewer unreferenced ones will be removed.

- Julian
Received on 2010-07-30 12:17:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.