RE: [PATCH] svn patch --add-to-cl

> -----Original Message-----
> From: Julian Foad [mailto:julian.foad_at_wandisco.com]
> Sent: woensdag 28 juli 2010 16:38
> To: Daniel Shahaf
> Cc: dev_at_subversion.apache.org
> Subject: Re: [PATCH] svn patch --add-to-cl
>
> On Sat, 2010-07-24, Daniel Shahaf wrote:
> > I've drilled a changelist into 'svn patch'.
> >
> > [[[
> > 0:% $svn st subversion
> > 0:% $svn patch ../diffs/svn-patch-add_to_cl.diff --add-to-cl cl
> > A [cl] subversion/tests/libsvn_client/client-test.c
> > U subversion/tests/libsvn_client/client-test.c
> [...]
> > 0:% $svn st --cl cl
> > --- Changelist 'cl':
> > M subversion/include/svn_client.h
> > M subversion/tests/libsvn_client/client-test.c
> [...]
> > ]]]
> >
> > Comments? Thoughts?
>
> You're talking about a totally new option, one that says "I'd like to
> add all the files affected to a (specified) changelist."
>
> That sounds like it could be a useful feature, but it doesn't sound
> like
> it should be specific to "svn patch" - if we have such a feature, I
> would expect to be able to use it with (more or less) all svn commands.
> Makes sense?

Yes, that makes sense... (I had the same thought yesterday)

But then I start thinking... where does it make sense...

'svn cp', no... doesn't work because changelists can't handle directories.
'svn add -R', no.. doesn't work... same reason
'svn rm' ...
'svn merge' ...
And so on.

I think we should really look at whether we can make changelists on directories in a sensible way. Then this would be a really useful feature!

The reason we disabled changelists on directories shortly before releasing 1.5 (if I remember correctly), was that we couldn't define how they were supposed to work on directories. And denying its use on directories would allow refining it later without breaking backwards compatibility./

Maybe we can enable it now if we can get it to work consistently. (Things start making more sense when you look at things using operation roots, like we do for the 4th tree).

        Bert
Received on 2010-07-28 18:09:43 CEST