[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r979429 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Wed, 28 Jul 2010 11:53:47 +0100

On Mon, 2010-07-26, rhuijben_at_apache.org wrote:
> Author: rhuijben
> Log:
> Enhance the detection of working copy corruptions for users of ra_serf,
> by passing a checksum to close_file(). This was in an attempt to fix
> copy_tests.py 89 on ra_serf, but it seems that the XPass of this test is
> caused by a different error/feature.
[...]

> + if (name_len == 12
> + && ns_len == 39
> + && strcmp(name, "md5-checksum") == 0
> + && strcmp(ns, SVN_DAV_PROP_NS_DAV) == 0)
> + info->final_checksum = apr_pstrdup(info->pool, val->data);

Can we lose the magic "39" please? And preferably the "12" as well,
though that one is not so bad because it's a local reference.

- Julian
Received on 2010-07-28 12:54:33 CEST

This is an archived mail posted to the Subversion Dev mailing list.