[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH 06/13] Dump the revprops at the start of every revision

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Mon, 26 Jul 2010 15:03:27 +0100

On Thu, 2010-07-22, Ramkumar Ramachandra wrote:
> Jonathan Nieder writes:
[...]
> > > + /* Output name length, then name. */
> > > + svn_stringbuf_appendcstr(*strbuf,
> > > + apr_psprintf(pool, "K %" APR_SSIZE_T_FMT "\n",
> > > + keylen));
> > > +
> > > + svn_stringbuf_appendbytes(*strbuf, (const char *) key, keylen);
> >
> > Is the cast needed? (The answer might be "yes" if this code is meant
> > to be usable with C++ compilers.)
>
> These casts are all over in the source tree, so I'm guessing the
> answer is "yes".

Actually no - Subversion C code is not intended to be compilable as C++
and that cast is not needed. (Other casts that you see in Subversion
code are for different situations.)

- Julian
Received on 2010-07-26 16:04:12 CEST

This is an archived mail posted to the Subversion Dev mailing list.