[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r979094 - /subversion/trunk/subversion/svnrdump/svnrdump.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 26 Jul 2010 15:38:41 +0200

On Mon, Jul 26, 2010 at 06:53:26PM +0530, Ramkumar Ramachandra wrote:
> Hi Stefan,
> Stefan Sperling writes:
> > What about doing one thing at a time instead?
> >
> > I'm not trying to be sarcastic or offensive, but you seem to be trying
> > to juggle too many things at once. Writing good code takes time. Maybe
> > if you focused more thoroughly on single tasks with a bit more patience
> > and stopped jumping around a lot, you'd end up making more progress
> > quicke. Because that will also make reviewing easier for us, because
> > whenever you jump to a different task, we have to jump as well.
> I totally agree with you. However, I'm a full-time student and I have
> very limited time to contribute. Anyway, I'll try not to be a cookie
> monster in future :p

Oh, I know that hacking time is scarce. Mine is, too.
And I'm happy that you are very active. But please forgive me when
I can't commit on every patch you send, or keep comments short.

> > Do you have any diffs that will make svnrdump output match svnadmin
> > dump output more closely? Or maybe commits already done that I missed?
> Yeah, I committed most of those changes. Currently, we're just missing
> the sha1sum headers, property checksums, and the occasional extra
> Prop-Delta header.

I'll get rid of property checksums in a minute. They were a bad idea.
So don't worry about those.

The Prop-Delta header should be looked at. It can't be that hard to not
behave the same as svnadmin dump there. The file content checksums might
need RA-layer changes, so it's a lot of work. I'll see about trying to chip
in there, at least taking a closer look to determine a good way of doing it.

Received on 2010-07-26 15:39:30 CEST

This is an archived mail posted to the Subversion Dev mailing list.