[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Import svnsync tests into svnrdump

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 26 Jul 2010 14:02:27 +0200

On Mon, Jul 26, 2010 at 05:17:07PM +0530, Ramkumar Ramachandra wrote:
> Hi,
>
> Ramkumar Ramachandra writes:
> > The tests in svnsync_tests_data/ are in dumpfile v2 and these are
> > unsuitable for testing svnrdump. Hence, load all of them into a
> > repository and re-dump them in dumpfile v3 format before attempting to
> > add them to svnrdump_tests_data/. I still have to figure out how to
> > extend the test framework to ignore certain headers in the diff-

What headers do you want to ignore?

> > currently, using run_test() in svnrdump to run tests corresponding to
> > these files will fail all tests.
>
> I've discussed this with Daniel on the channel, and I've told him that
> I specifically want this because we don't want svnrdump tests to
> depend on svnadmin. Does anyone object to this patch? It was created
> by dumping the data in svn-test-data/ after running svnsync_tests.py.
>
> Thanks.

As long as we still try to make svnrdump output make svnadmin dump output
match as much as possible, I don't object to adding v3 dump files for
svnrdump tests. That's obviously necessary because svnrdump can only do v3.

But I'd rather like this to be done one step at a time.
Please don't import test data that isn't used. Write the test using
the data, and then add the data along with the (passing or xfailing) test.

So I'd like to see a new diff with test+data before I can give a +1.
Preferably one diff per test.

Stefan
Received on 2010-07-26 14:03:10 CEST

This is an archived mail posted to the Subversion Dev mailing list.