[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r978841 - in /subversion/trunk/subversion/tests/cmdline: svnrdump_tests.py svnrdump_tests_data/ svnrdump_tests_data/revision0.dump

From: Ramkumar Ramachandra <artagnon_at_gmail.com>
Date: Sat, 24 Jul 2010 16:28:49 +0530

Hi Daniel,

Daniel Shahaf writes:
> Not your fault, but that's not what I meant. What I meant was to check for no
> unexpected stderr (e.g., no "svn: warning %s" or similar).
>
> For example, you could do that by running 'svnrdump -q' and then verifying that
> *nothing* was printed to stderr.

Is this alright?

[[[
* cmdline/svnrdump_tests.py (run_test): Run svnrdump with '-q' and
  check that nothing is printed to stderr.

Review by: danielsh
]]]

Index: subversion/tests/cmdline/svnrdump_tests.py
===================================================================
--- subversion/tests/cmdline/svnrdump_tests.py (revision 978841)
+++ subversion/tests/cmdline/svnrdump_tests.py (working copy)
@@ -73,15 +73,15 @@ def run_test(sbox, dumpfile_name):
   svntest.actions.run_and_verify_load(sbox.repo_dir, svnadmin_dumpfile)
 
   # Create a dump file using svnrdump
- r, svnrdump_dumpfile, err = svntest.main.run_svnrdump(sbox.repo_url)
+ r, svnrdump_dumpfile, err = svntest.main.run_svnrdump('-q', sbox.repo_url)
 
   # Check error code
   if (r != 0):
     raise svntest.Failure('Result code not 0')
 
   # Check the output from stderr
- if not err[0].startswith('* Dumped revision'):
- raise svntest.Failure('No valid output')
+ if err:
+ raise svntest.Failure('Error while running')
 
   # Compare the output from stdout
   svntest.verify.compare_and_display_lines(
Received on 2010-07-24 13:01:17 CEST

This is an archived mail posted to the Subversion Dev mailing list.