Re: [PATCH v2] Add svnrdump

Hi Daniel,

Daniel Shahaf writes:
> Good question.
>
> I'd probably say "last revision successfully dumped was rN" and then exit with
> a non-zero code, leaving it to the admin to clean up the mess (i.e., to truncate
> the dumpfile after the end of rN's data).
>
> Unfortunately, since you dump to stdout, you can't do that seek+truncate yourself :-(

Yeah, this makes sense.

> > can we just look for
> > "^Revision-number: \d+$" from the bottom of the file, clean it up and
> > then resume?
> >
>
> What if a file contains that line as part of its content?

Hm. Maybe it'll make sense to keep track of the total content length
successfully written so that we can truncate. But as Stefan pointed,
we can think about this again in a few days- it's not urgent.

-- Ram
Received on 2010-07-23 22:59:09 CEST