[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r966841 - /subversion/trunk/subversion/svnrdump/svnrdump.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 23 Jul 2010 22:24:18 +0300

Ramkumar Ramachandra wrote on Fri, Jul 23, 2010 at 23:50:00 +0530:
> > > + /* Fake properties from svnsync ### what about svn:date? */
> > > + apr_hash_set(encoded_prophash, SVNSYNC_PROP_FROM_URL,
> > > + APR_HASH_KEY_STRING, svn_string_create(url, pool));
> > > + apr_hash_set(encoded_prophash, SVNSYNC_PROP_FROM_UUID,
> > > + APR_HASH_KEY_STRING, svn_string_create(uuid, pool));
> > > + apr_hash_set(encoded_prophash, SVNSYNC_PROP_LAST_MERGED_REV,
> > > + APR_HASH_KEY_STRING, svn_string_createf(pool, "%ld",
> > > + end_revision));
> > > + apr_hash_set(encoded_prophash, SVNSYNC_PROP_CURRENTLY_COPYING,
> > > + APR_HASH_KEY_STRING, svn_string_createf(pool, "%ld",
> > > + end_revision));
> > > +
> > > + propstream = svn_stream_from_stringbuf(propstring, pool);
> >
> > Huh? Just use svn_stream_empty(), since propstring is always "" here.
>
> Er, that would defeat the point of writing the hash to the stream (and
> consequently to the stringbuf).

Ah, I see. I didn't look for uses of propstring after this assignment;
obviously I wasn't familiar enough with svn_stream_from_stringbuf() when I
wrote the review :-)

Thanks.

Daniel
Received on 2010-07-23 21:25:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.