Re: hotcopy fails on fsfs.conf that has never been created

On Fri, Jul 23, 2010 at 07:39:22PM +0300, Daniel Shahaf wrote:
> Old repositories don't have a fsfs.conf file. I think we should either make
> 'hotcopy' tolerate the absence of that file, or make 'svnadmin upgrade' create
> it; otherwise,
>
> svnadmin1.5 create foo
> svnadmin1.7 hotcopy foo bar
>
> will fail with the error Александр quotes.
>
>
> Anybody has a preference regarding which solution to take?

This has come up before: http://svn.haxx.se/users/archive-2010-04/0393.shtml

If the file is gone because of the bug which existed in hotcopy
from 1.6.0 to 1.6.11, people won't notice that the file is missing
if we silently tolerate the fact that it's missing.
So -1 on silently ignoring the file's absence.

So my vote is: leave it as is, but print a more informative error message
suggesting to create the file (so that people don't have to post to
users@ to be instructed to do so), and make svnadmin upgrade create it.

I should have been more considerate when making the original fix and
done the above at that time... :( It didn't occur to me that fsfs.conf
might not exist at all in older versions.

Stefan
Received on 2010-07-23 19:35:36 CEST