[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.6.x backport of "svnadmin hotcopy" for symlinks - API change?

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 23 Jul 2010 13:13:43 -0400

On 06/17/2010 09:47 AM, Daniel Shahaf wrote:
> Julian Foad wrote on Thu, 17 Jun 2010 at 14:53 +0100:
>> On Wed, 2010-06-16, C. Michael Pilato wrote:
>>> If we decide that we need to rev this API, though, then let's do the sane
>>
>> (Did you mean "rev this API" or merely "change it in any way"?)
>>
>>> thing and teach the function to return *all* the known APR file types so we
>>> don't have to revisit this API again later. We can backport a private
>>> implementation of the function for the purposes of fixing the bug in 1.6.x.
>>
>> Yes, we might as well make svn_io_dir_walk() return all possible kinds
>> of node, now that we're changing it at all.
>>
>
> Or we might say: "This returns APR_REG, APR_DIR, and may return more types
> in the future; don't assume this is an exhaustive list".
>
>> Oh, and the doc string needs updating: it explicitly says "files and
>> directories".
>>
>
> Symlinks are files? In a way? :-)
>
> (Yes, couldn't hurt to be explicit.)

I'm revving svn_io_dir_walk() now, and building into the new docstring the
possibility that we'll deliver additional filetypes through the interface in
the future.

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2010-07-23 19:14:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.