[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH v2] Add svnrdump

From: Ramkumar Ramachandra <artagnon_at_gmail.com>
Date: Fri, 23 Jul 2010 21:39:46 +0530

Hi Stefan,

Stefan Sperling writes:
> svnrdump is something entirely different to svnsync.
> svnrdump is analogous to 'svnadmin dump', which does not create any
> svn:sync-* properties itself. It just dumps them if they are already
> there. So if you dump a repository which was mirrored using svnsync,
> you will see svn:sync-* properties on r0. If you dump a repository
> which was not mirrored with svnsync (either it's the original one or
> a clone created with svnadmin load), then you won't see any svn:sync-*
> properties.
>
> So that's why creating the svn:sync-* revision properties is not
> svnrdump's business.

That's true, but don't you want resume support sometime? True, we'll
actually have to read the dumpfile to figure out how many revision
have been dumped to figure out what to append to it, but still.

> Just play a bit with dumping repositories created with 'svnadmin create'
> and dumping repositories mirrored with svnsync for additional insight.
>
> > > - You're missing a couple of fields:
> > > The UUID of the repository.
> >
> > Fixed.
> >
> > > Text-content-sha1
> >
> > As I pointed out, this is a wontfix.
>
> Doesn't the replay API provide the checksums?

No, it only provides an md5sum, but no sha1sum.

> > > Text-delta-base-md5
> >
> > I dug deeper, but it seems like I don't get this information over the
> > wire: to actually implement this, I'll have to fetch the file to which
> > the delta is being applied along with its md5sum. If this isn't worth
> > the trouble, it again becomes a wontfix.
>
> Same. If the replay API does not provide enough information, we should
> try to extend the replay API to meet svnrdump's needs.
> Do you want to try to do this? This is outside of your partial commit
> access area, but that alone should not discourage you from trying to
> improve the replay API if svnrdump can benefit from it.
>
> You'll need to learn a bit about how we extend our APIs and keep
> backwards compatibility at the same time. But we'll be glad to help.
>
> For starters, you could try to implement replay of revision 0, so that
> any revision properties set on revision 0 will be replayed.

Excellent idea. I'll try it right away.

-- Ram
Received on 2010-07-23 18:12:24 CEST

This is an archived mail posted to the Subversion Dev mailing list.