Re: [PATCH v2] Add svnrdump

Hi again,

With the latest fixes, I thought I'd follow up on this.

Stefan Sperling writes:
> - svnrdump doesn't dump revision 0.
> It should dump revision 0, because that revision can contain important
> revprops such as metadata for svnsync (svn:sync-last-merge-rev etc.)

Fixed. After a few more experiments, I figured that I'd misunderstood
something- thanks to Philip for poking me harder. After many
inconsistent results, I found out that svn:sync-* properties are
transmitted via svn_ra_rev_proplist when a mirror steps in (... and
this results in svnsync being called).

> - You're missing a couple of fields:
> The UUID of the repository.

Fixed.

> Text-content-sha1

As I pointed out, this is a wontfix.

> Text-delta-base-md5

I dug deeper, but it seems like I don't get this information over the
wire: to actually implement this, I'll have to fetch the file to which
the delta is being applied along with its md5sum. If this isn't worth
the trouble, it again becomes a wontfix.

> Text-delta-base-sha1

Wontfix.

> - I've seen a "Prop-delta: true" line which svnadmin dump does not print.

I still haven't figured out if this is worth the trouble.

> - You're missing some newlines that svnadmin dump prints (cosmetic,
> but it would be nice if both produced matching output).

Fixed. On the refactored codebase, it just took me an hour to think
through this and fix it :)

-- Ram
Received on 2010-07-23 14:43:34 CEST