[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH v2] Add svnrdump

From: Ramkumar Ramachandra <artagnon_at_gmail.com>
Date: Thu, 22 Jul 2010 00:33:24 +0530

Hi Stefan,

Stefan Sperling writes:
> Copy of what and when? This baton is global for the entire edit...
> Going through the code, I see that you're using this to indicate to
> dump_node() whether an add_directory() or add_file() was in fact a copy.
> Why not remove this field from the struct and add it as a parameter to
> dump_node instead?

This is an excellent catch! It's in the editor baton for historical
reasons- cleaned up with my latest commit.

Thanks :)

-- Ram
Received on 2010-07-21 21:06:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.