Re: [PATCH] Add a '--fsfs-no-repsharing' flag to svnadmin

Daniel Shahaf wrote on Tue, Jul 20, 2010 at 23:05:45 +0300:
> Hyrum K. Wright wrote on Tue, Jul 20, 2010 at 11:29:38 -0500:
> > On Jul 20, 2010, at 9:32 AM, Simon Atanasyan <simon_at_visualsvn.com> wrote:
> > > I am not sure that SQLite locking works correctly over network share
> > > due the limit file level locking support offered by OS for network shares.
> > > SQLite is used for repository sharing so it may lead to repository corruption.
> > > svnadmin and filesystem configuration options help users control this issue.
> >
> > Additionally, if the underlying filesystem doesn't support locking correctly,
> > you've got bigger problems than SQLite behavior. :)

Yep. I asked about this when sqlite was introduced, and the answer was
that sqlite and fsfs rely on the same locks interface for their operation.

In other words, sqlite would work anywhere fsfs already works... but
conversely, if the locks break sqlite, then they break fsfs too.
Received on 2010-07-20 22:31:56 CEST