[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r964704 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 16 Jul 2010 19:29:09 +0100

Greg Stein <gstein_at_gmail.com> writes:

> Yes, svn_sqlite__update() *does* reset the statement before returning
> (it isn't something where you can iterate over results; it is done; so
> it resets the statement).
>
> Thus, the extra reset should not be there. "Following the pattern"
> isn't right here.

Ah, I didn't understand Bert's point. So we need a NULL.

>
>
> On Fri, Jul 16, 2010 at 13:44, Philip Martin <philip.martin_at_wandisco.com> wrote:
>> Bert Huijben <bert_at_qqmail.nl> writes:
>>
>>> Doesn't _update handle this specific reset? If not I think it should.
>>
>> The compiler was complaing about a missing argument to
>> svn_error_createf.  I was just following the pattern used by next
>> function.
>>
>>>    if (affected_rows != 1)
>>>      return svn_error_createf(SVN_ERR_WC_PATH_NOT_FOUND,
>>> +                             svn_sqlite__reset(stmt),
>>>                               _("The node '%s' was not found."),
>>>                               svn_dirent_local_style(local_abspath,
>>>                                                      scratch_pool));
>>
>> --
>> Philip
>>
>

-- 
Philip
Received on 2010-07-16 20:30:07 CEST

This is an archived mail posted to the Subversion Dev mailing list.