Hi,
Jonathan Nieder writes:
> Ramkumar Ramachandra wrote:
>
> > Here's a diff of the modifications I made after your review:
>
> That’s quite helpful.
>
> > +++ b/svndumpr.c
> > @@ -76,31 +76,19 @@ static svn_error_t *replay_revend(svn_revnum_t revision,
> [...]
> > + /* Populte ctx->auth_baton with the auth baton
> > + non-interactively. Arguments 3, 4 and 5 are for username,
> > + password and config_dir which is NULL in this case. Set
> > + no_auth_cache and trust_serv_cert to FALSE, don't provide a
> > + config, and omit cancel_func/ cancel_baton */
> > SVN_ERR(svn_cmdline_create_auth_baton(&(ctx->auth_baton), TRUE,
> > NULL, NULL, NULL, FALSE,
> > FALSE, NULL, NULL, NULL,
>
> I think you took my suggestion too seriously here. Such a comment
> probably will not help people much; instead, maybe a more focused
> comment can help the curious avoid looking up
> svn_cmdline_create_auth_baton:
>
> /* Default authentication providers for noninteractive
> use. */
> SVN_ERR(svn_cmdline_create_auth_baton(...
Fixed.
> Looking this up, I notice that function was added in svn 1.6.
> Hopefully that is okay, since this code is destined for svn trunk.
I have a working 1.6 fork now that I intend to merge into
git.git. When there's a new release of Subversion that includes my
patch, I'll remove it from git.git.
> Reviewed-by: Jonathan Nieder <jrnieder_at_gmail.com>
Thanks.
-- Ram
Received on 2010-07-07 22:45:59 CEST